Replace shared(apiKey:) with configure() and setJWT by tomas-martins-crossmint · Pull Request #91 · Crossmint/crossmint-swift-sdk

tomas-martins-crossmint · 2026-05-21T18:03:47Z

The old CrossmintSDK.shared(apiKey:authManager:logLevel:) was a factory method pretending to be a property. You had to pass a CrossmintAuthManager to it, keep that instance around separately for JWT auth and logout, and call two different methods just to sign out.

This pull request replaces it with a configure-then-access pattern and moves auth management fully onto the singleton.

Changes

Replaced shared(apiKey:authManager:logLevel:) with configure(apiKey:logLevel:). shared is now read-only and crashes with a clear message if accessed before configuration.
Added setJWT(_ jwt: String) async directly on CrossmintSDK. No more keeping a separate CrossmintAuthManager reference just to set a JWT.
logout() now handles both auth cleanup and TEE reset in one call and drops throws, since errors were always swallowed internally.
crossmintNonCustodialSigner() is now no-arg. Passing the SDK instance was redundant since there's only one.
authManager is typed as CrossmintAuthManager throughout, removing the internal force cast.

API changes

This pull request introduces breaking changes, requiring small changes from end users of the SDK:

SDK initialization

// Before
let sdk = CrossmintSDK.shared(apiKey: "ck_...", logLevel: .info)

// After
CrossmintSDK.configure(apiKey: "ck_...", logLevel: .info)
let sdk = CrossmintSDK.shared

JWT authentication

// Before
await authManager.setJWT(token)

// After
await CrossmintSDK.shared.setJWT(token)

Logout

// Before
try? await CrossmintSDK.shared.logout()

// After
await CrossmintSDK.shared.logout()

Non-custodial signer modifier

// Before
.crossmintNonCustodialSigner(sdk)

// After
.crossmintNonCustodialSigner()

…ogout on CrossmintSDK

… access patterns

…om logout()

…sleep in demo

… access in demo

… crossmintTEE in body

greptile-apps · 2026-05-22T18:59:21Z

Prompt To Fix All With AI

Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
Sources/CrossmintClient/SwiftUI/CrossmintSDK.swift:44-46
Missing indentation on `private let sdk`. The property declaration is flush against the left margin instead of being indented to match the rest of the class body, which appears to be a diff artifact from the refactor.

```suggestion
    private let sdk: ClientSDK

    public let crossmintWallets: CrossmintWallets
```

### Issue 2 of 2
Sources/CrossmintClient/SwiftUI/View+NonCustodialSigner.swift:37
`CrossmintSDK.shared` is accessed on every SwiftUI render pass inside `body(content:)`. Because `crossmintTEE` is a `let` constant on the singleton this always returns the same object and is functionally correct, but accessing the singleton each render is inconsistent with how the old code captured the reference at init time. If `configure()` has not been called before the first render (e.g. if the modifier is somehow applied before `init()` runs), this will `fatalError` with a less obvious callsite than a misconfiguration at startup.

_{Reviews (1): Last reviewed commit: "Remove Configuration struct — add back i..." | Re-trigger Greptile}

afeight · 2026-05-27T15:58:08Z

+        do {
+            _ = try await authManager.logout()
+        } catch {
+            Logger.sdk.warn("Logout request failed: \(error) — clearing local state anyway")


what can happen here if we're not logged out but clear local state? What's the difference?

the intent was to avoid locking users out if the logout endpoint request fails. But on the current implementation, if that request throws, we'd also never clear the user's JWT and refresh tokens from keychain, which could lead to the user getting automatically logged in on the next app launch, if the client doesn't have any safeguards to that

the only part that can throw is the logout network call, so we could clear the credentials before making the request instead, so even if that fails, the client would still lose access to the JWT and the user wouldn't end up accidentally being signed in again, regardless of the request result

nah all good as-is, didn't realize we have a logout network request

afeight · 2026-05-27T16:05:40Z

+        let components = Self.makeComponents(apiKey: apiKey)
+        sdk = components.sdk
+        crossmintWallets = components.wallets
+        authManager = components.authManager
+        crossmintService = components.service
+        crossmintTEE = components.tee


this is what I mean, I think it stems also from the try/catch maybe? Which step can actually throw? If we want to condense the code, i'd be thinking more:

do { let sdk = try CrossmintClient.sdk(key: apiKey) } catch { ... } initialize(with: sdk)

with initialize being

self.crossmintWallets = sdk.crossmintWallets() self.authManager = sdl.authManager self.crossmintService = sdk.crossmintService self.crossmintTEE = CrossmintTEE.start( ...

yeah, on a second look the whole Components was just some unnecessary ceremony. I've inlined everything into the initializer

greptile-apps · 2026-05-27T21:30:15Z

Prompt To Fix All With AI

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
Sources/CrossmintClient/SwiftUI/CrossmintSDK.swift:17-25
**DEBUG env-var escape hatch removed**

The previous `private convenience init()` supported a `#if DEBUG` branch that would read `CROSSMINT_API_KEY` from `ProcessInfo.processInfo.environment`, allowing Xcode Previews and simulator runs to boot the SDK without an explicit `configure()` call. That path is gone. Any `#Preview` block that renders a view whose `.task { }` or `init` accesses `CrossmintSDK.shared` (e.g. `SplashScreen`, whose `authenticate()` is invoked via `.task`) will now unconditionally hit the `fatalError`. This is a DX regression for teams that relied on the env-var injection for quick previewing or CI simulator tests.

_{Reviews (2): Last reviewed commit: "Remove Components struct, inline SDK ini..." | Re-trigger Greptile}

greptile-apps · 2026-05-27T22:50:45Z

Prompt To Fix All With AI

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
Sources/CrossmintClient/SwiftUI/CrossmintSDK.swift:29-36
**`DEBUG` env-var escape hatch removed — SwiftUI previews will now crash**

The previous no-arg `init()` checked `ProcessInfo.processInfo.environment["CROSSMINT_API_KEY"]` in `#if DEBUG` and used it to self-configure, giving previews a zero-config path. That fallback is gone from `configure()`. Any `#Preview { SplashScreen() }` (or similar) will now hit the `fatalError` in `shared` because `configure()` was never called in that process. Developers who relied on the env-var shortcut for local iteration will need an alternative (e.g. a no-op stub or a preview-specific `configure()` call in the preview block).

_{Reviews (3): Last reviewed commit: "Capture crossmintTEE reference at modifi..." | Re-trigger Greptile}

greptile-apps · 2026-05-27T22:53:55Z

Prompt To Fix All With AI

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
Sources/CrossmintClient/SwiftUI/CrossmintSDK.swift:40-42
`crossmintService` is exposed as `public let`, which makes the internal service layer part of the SDK's public API surface. Previously only `isProductionEnvironment: Bool` was public (and it still is, as a computed property on line 56). Any consumer that stores a reference to `crossmintService` today will become a dependant of that internal type, making it harder to refactor or change the service layer later without a breaking change.

```suggestion
    public let crossmintWallets: CrossmintWallets
    public let authManager: CrossmintAuthManager
    let crossmintService: CrossmintService
```

_{Reviews (4): Last reviewed commit: "Merge main, resolve conflicts" | Re-trigger Greptile}

tomas-martins-crossmint added 7 commits May 21, 2026 11:13

Add Configuration struct, configure() API, setJWT, and consolidated l…

4a82e63

…ogout on CrossmintSDK

Update SmartWalletsDemo to use CrossmintSDK.configure() and singleton…

f1a7196

… access patterns

Add doc comments, extract makeComponents, and drop spurious throws fr…

5a6233c

…om logout()

Deduplicate authManager property and replace DispatchQueue with Task.…

adb95c5

…sleep in demo

Move Components before init, fix double blank line, unify authManager…

f2b3580

… access in demo

Mark demo authManager var @mainactor

eb13ddf

Make CrossmintNonCustodialSignerViewModifier stateless — lazy-capture…

d7f3d08

… crossmintTEE in body

tomas-martins-crossmint changed the title ~~New configure() API, Configuration struct, setJWT, and consolidated logout~~ SDK setup: configure(), Configuration, setJWT May 21, 2026

tomas-martins-crossmint added 2 commits May 21, 2026 15:37

Log logout errors instead of silently swallowing them

e7df3a0

Remove Configuration struct — add back if needed

e3ed53f

tomas-martins-crossmint changed the title ~~SDK setup: configure(), Configuration, setJWT~~ SDK setup: configure(), setJWT May 21, 2026

tomas-martins-crossmint changed the title ~~SDK setup: configure(), setJWT~~ Replace shared(apiKey:) with configure() and setJWT May 21, 2026

tomas-martins-crossmint marked this pull request as ready for review May 22, 2026 18:55

tomas-martins-crossmint requested a review from afeight May 22, 2026 18:58

greptile-apps Bot reviewed May 22, 2026

View reviewed changes

Comment thread Sources/CrossmintClient/SwiftUI/CrossmintSDK.swift Outdated

Comment thread Sources/CrossmintClient/SwiftUI/View+NonCustodialSigner.swift Outdated